Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> Hello Eric Anholt,
>
> The patch d5b1a78a772f: "drm/vc4: Add support for drawing 3D frames."
> from Nov 30, 2015, leads to the following static checker warning:
>
> drivers/gpu/drm/vc4/vc4_gem.c:797 vc4_wait_for_seqno_ioctl_helper()
> warn: ret is never (-4)
>
> drivers/gpu/drm/vc4/vc4_gem.c
> 790 static int
> 791 vc4_wait_for_seqno_ioctl_helper(struct drm_device *dev,
> 792 uint64_t seqno,
> 793 uint64_t *timeout_ns)
> 794 {
> 795 unsigned long start = jiffies;
> 796 int ret = vc4_wait_for_seqno(dev, seqno, *timeout_ns, true);
> 797
> 798 if ((ret == -EINTR || ret == -ERESTARTSYS) && *timeout_ns != ~0ull) {
> ^^^^^^^^^^^^^
> Presumably this could be removed?
I think so. Want to send the patch?
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
