Re: [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 05, 2016 at 11:00:03AM +0200, Gustavo Padovan wrote:
> Hi Stefan,
> 
> 2016-10-04 Stefan Christ <contact@xxxxxxxxxxxxxxx>:
> 
> > The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> > implementations for functions in struct fb_ops. A drm driver can use it
> > like:
> > 
> >     static struct fb_ops drm_fbdev_cma_ops = {
> >         .owner          = THIS_MODULE,
> >         DRM_FB_HELPER_DEFAULT_OPS,
> >         /* driver specific implementations */
> >     };
> > 
> > Suggested-by: Daniel Vetter <daniel@xxxxxxxx>
> > Signed-off-by: Stefan Christ <contact@xxxxxxxxxxxxxxx>
> > ---
> > v2: Fix sphinx error:
> >      warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
> > ---
> >  include/drm/drm_fb_helper.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> > index db8d478..f7d7126 100644
> > --- a/include/drm/drm_fb_helper.h
> > +++ b/include/drm/drm_fb_helper.h
> > @@ -214,6 +214,19 @@ struct drm_fb_helper {
> >  	bool delayed_hotplug;
> >  };
> >  
> > +/**
> > + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
> 
> If I'm not mistaken v1 of this patch is already in drm-misc so you may
> want to send a patch that fix just the line above.

Yup, I need an incremental patch which applies on top of drm-misc or
linux-next. Sorry if this wasn't clear.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux