On 09/30/16 12:35, Hans de Goede wrote: > Attached are 2 patches against the xserver which should fix this, > please give them a try. Sorry about the delay. The patches don't seem to fix the issue for me. Please see the Xorg log attached. I tested the patches as follows. Given that my bisection had been done in a Fedora 24 guest, using xorg-x11-server-1.18.4-4.fc24 http://koji.fedoraproject.org/koji/buildinfo?buildID=794494 I now rebuilt the guest kernel exactly at the failing commit (a325725 "drm: Lobotomize set_busid nonsense for !pci drivers"), and first reproduced the issue with the above X server. Then, I ported your patches to "xorg-server-1.18.4" (using the upstream xserver tree), and rebuilt the Fedora package with the backport. For the backport, I had to cherry-pick the following two patches from master first: 1 ca8d88e50310 xfree86: recognize primary BUS_PCI device in xf86IsPrimaryPlatform() 2 ea91db4b8331 config: fix GPUDevice fail when AutoAddGPU off + BusID This way your patches applied cleanly. (Cherry pick #1 above is actually necessary for semantics, while cherry pick #2 is needed for a clean context only, and has no impact for this test.) That is, in total, I added the following four patches to the Fedora 24 package: 1 xfree86: recognize primary BUS_PCI device in xf86IsPrimaryPlatform() 2 config: fix GPUDevice fail when AutoAddGPU off + BusID 3 xfree86: Make adding unclaimed devices as GPU devices a separate step 4 xfree86: Try harder to find atleast 1 non GPU Screen You can find the scratch build that I used for testing here: xorg-x11-server-1.18.4-4.hans_bz1366842_2.fc24 http://koji.fedoraproject.org/koji/taskinfo?taskID=15875087 Another reason I used F24's X server as basis, rather than upstream HEAD, is that Fedora 24 is pretty young, and it's already on kernel 4.7.4, and I believe it will soon move to kernel 4.8, without (necessarily) rebasing its X server package to upstream. IOW the kernel upgrade to 4.8 will break X in Fedora 24 too, and then I expect the Fedora X maintainers would have to cherry pick those two patches as dependencies just the same. To summarize, the patches don't seem to help. I shall nonetheless thank you for spending your Friday on this! Laszlo
[ 9.841] X.Org X Server 1.18.4 Release Date: 2016-07-19 [ 9.842] X Protocol Version 11, Revision 0 [ 9.842] Build Operating System: 4.7.2-201.fc24.x86_64 [ 9.842] Current Operating System: Linux ovmf-fedora 4.7.0-rc2+ #7 SMP Fri Sep 30 12:05:35 CEST 2016 x86_64 [ 9.842] Kernel command line: BOOT_IMAGE=/vmlinuz-4.7.0-rc2+ root=/dev/mapper/fedora-root ro rd.lvm.lv=fedora/swap vconsole.font=latarcyrheb-sun16 rd.lvm.lv=fedora/root rhgb quiet video=640x480 no_console_suspend console=tty console=ttyS0,115200 ignore_loglevel LANG=en_US.UTF-8 [ 9.842] Build Date: 30 September 2016 02:16:20PM [ 9.842] Build ID: xorg-x11-server 1.18.4-4.hans_bz1366842_2.fc24 [ 9.842] Current version of pixman: 0.34.0 [ 9.842] Before reporting problems, check http://wiki.x.org to make sure that you have the latest version. [ 9.842] Markers: (--) probed, (**) from config file, (==) default setting, (++) from command line, (!!) notice, (II) informational, (WW) warning, (EE) error, (NI) not implemented, (??) unknown. [ 9.842] (==) Log file: "/var/log/Xorg.0.log", Time: Fri Sep 30 16:32:21 2016 [ 9.842] (==) Using config directory: "/etc/X11/xorg.conf.d" [ 9.842] (==) Using system config directory "/usr/share/X11/xorg.conf.d" [ 9.842] (==) No Layout section. Using the first Screen section. [ 9.842] (**) |-->Screen "Default Screen" (0) [ 9.842] (**) | |-->Monitor "Default Monitor" [ 9.842] (**) | |-->Device "Default Device" [ 9.842] (==) Automatically adding devices [ 9.842] (==) Automatically enabling devices [ 9.842] (==) Automatically adding GPU devices [ 9.842] (==) Max clients allowed: 256, resource mask: 0x1fffff [ 9.842] (==) FontPath set to: catalogue:/etc/X11/fontpath.d, built-ins [ 9.843] (==) ModulePath set to "/usr/lib64/xorg/modules" [ 9.843] (II) The server relies on udev to provide the list of input devices. If no devices become available, reconfigure udev or disable AutoAddDevices. [ 9.843] (II) Loader magic: 0x825dc0 [ 9.843] (II) Module ABI versions: [ 9.843] X.Org ANSI C Emulation: 0.4 [ 9.843] X.Org Video Driver: 20.0 [ 9.843] X.Org XInput driver : 22.1 [ 9.843] X.Org Server Extension : 9.0 [ 9.843] (++) using VT number 1 [ 9.843] (II) systemd-logind: logind integration requires -keeptty and -keeptty was not provided, disabling logind integration [ 9.844] (II) xfree86: Adding drm device (/dev/dri/card0) [ 9.848] (--) PCI:*(0:0:2:0) 1af4:1050:1af4:1100 rev 1, Mem @ 0xc0000000/8388608, 0x800000000/16384, 0xc0804000/4096, BIOS @ 0x????????/131072 [ 9.849] (II) LoadModule: "glx" [ 9.849] (II) Loading /usr/lib64/xorg/modules/extensions/libglx.so [ 9.851] (II) Module glx: vendor="X.Org Foundation" [ 9.851] compiled for 1.18.4, module version = 1.0.0 [ 9.851] ABI class: X.Org Server Extension, version 9.0 [ 9.851] (==) AIGLX enabled [ 9.851] (II) LoadModule: "modesetting" [ 9.851] (II) Loading /usr/lib64/xorg/modules/drivers/modesetting_drv.so [ 9.851] (II) Module modesetting: vendor="X.Org Foundation" [ 9.851] compiled for 1.18.4, module version = 1.18.4 [ 9.851] Module class: X.Org Video Driver [ 9.851] ABI class: X.Org Video Driver, version 20.0 [ 9.851] (II) modesetting: Driver for Modesetting Kernel Drivers: kms [ 9.851] (WW) Falling back to old probe method for modesetting [ 9.851] (II) modeset(1): using default device [ 9.852] (II) modeset(G0): using drv /dev/dri/card0 [ 9.852] (EE) Screen 0 deleted because of no matching config section. [ 9.852] (II) UnloadModule: "modesetting" [ 9.852] (EE) Fatal server error: [ 9.852] (EE) Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices [ 9.852] (EE) [ 9.852] (EE) Please consult the Fedora Project support at http://wiki.x.org for help. [ 9.852] (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information. [ 9.852] (EE) [ 9.853] (EE) Server terminated with error (1). Closing log file.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
