Hi Baoyou, On Sun, Sep 25, 2016 at 03:20:24PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes] > drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> I've already acked this patch: https://lists.freedesktop.org/archives/dri-devel/2016-September/117624.html What is going on between you and Ville Syrjälä? Both are posting the same patch. Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_planes.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c > index 725098d..5f8bece 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -46,7 +46,8 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) > devm_kfree(plane->dev->dev, mp); > } > > -struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) > +static struct > +drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) > { > struct malidp_plane_state *state, *m_state; > > @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) > return &state->base; > } > > -void malidp_destroy_plane_state(struct drm_plane *plane, > +static void malidp_destroy_plane_state(struct drm_plane *plane, > struct drm_plane_state *state) > { > struct malidp_plane_state *m_state = to_malidp_plane_state(state); > -- > 2.7.4 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
