On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: > > Hm, maybe we should simply not call ->lastclose for kms drivers. That is > > kinda only a hack for ums/dri1 drivers. > > Are you sure about that - isn't it needed so that the fbdev mode gets > restored when the last DRM user exits, so that the VT consoles becomes > functional again? > > I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked() > in Armada's ->lastclose to ensure that VT consoles worked after Xorg was > shutdown. I meant not call it on driver unload. When closing the last drm fd we indeed need it to restore the fbdev vt. That use-case definitely needs to stay for kms drivers. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
