On Thu, Sep 22, 2016 at 8:28 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> On 21 September 2016 at 15:59, Tom Gundersen <teg@xxxxxxx> wrote:
>> If passing name == NULL to drm_drv_set_unique() we now get -ENOMEM
>> as kstrdup() returns NULL. Instead check for this explicitly and
>> return -EINVAL if no name is provided.
>>
>> Signed-off-by: Tom Gundersen <teg@xxxxxxx>
>> ---
>> drivers/gpu/drm/drm_drv.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>> index f2f6429..99e6751 100644
>> --- a/drivers/gpu/drm/drm_drv.c
>> +++ b/drivers/gpu/drm/drm_drv.c
>> @@ -338,6 +338,9 @@ void drm_minor_release(struct drm_minor *minor)
>>
>> static int drm_dev_set_unique(struct drm_device *dev, const char *name)
>> {
>> + if (!name)
>> + return -EINVAL;
>> +
> From memory there should be no open-source drivers where this happens
> today. Either way, having a big WARN/OOPS would be better, imho, since
> it will point to the driver bug/issue (?).
Yeah, I only hit this during development, should not happen with any
upstream drivers afaik. Feel free to drop this patch for now.
Cheers,
Tom
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
