Re: [PATCH 14/21] drm: Extract drm_connector.[hc]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2016 at 10:48:50PM +0200, Daniel Vetter wrote:
> Pulls in quite a lot of connector related structures (cmdline mode,
> force/status enums, display info), but I think that all makes perfect
> sense.
> 
> Also had to move a few more core kms object stuff into drm_modeset.h.
> 
> And as a first cleanup remove the kerneldoc for the 2 connector IOCTL
> - DRM core docs are aimed at drivers, no point documenting internal in
> excruciating detail.
> 
> v2: And also pull in all the connector property code.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> ---
>  Documentation/gpu/drm-kms.rst       |    9 +
>  drivers/gpu/drm/Makefile            |    2 +-
>  drivers/gpu/drm/drm_connector.c     | 1058 +++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/drm_crtc.c          | 1110 +----------------------------------
>  drivers/gpu/drm/drm_crtc_internal.h |   26 +-
>  include/drm/drm_connector.h         |  644 ++++++++++++++++++++
>  include/drm/drm_crtc.h              |  601 +------------------
>  include/drm/drm_modes.h             |   16 +-
>  include/drm/drm_modeset.h           |   36 +-
>  9 files changed, 1773 insertions(+), 1729 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_connector.c
>  create mode 100644 include/drm/drm_connector.h
> 

<snip>

> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index f4d041800551..e30ea0be6417 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h


<snip>

> -
> -#define MAX_ELD_BYTES	128
> -

Building drm-misc-arm gives:

../sound/soc/codecs/hdmi-codec.c:34:14: error: ‘MAX_ELD_BYTES’ undeclared here
(not in a function)
make[4]: *** [sound/soc/codecs/hdmi-codec.o] Error 1
make[3]: *** [sound/soc/codecs] Error 2
make[2]: *** [sound/soc] Error 2
make[2]: *** Waiting for unfinished jobs....



>From hdmi-codec.c:

#include <drm/drm_crtc.h> /* This is only to get MAX_ELD_BYTES */


I can post a patch tomorrow morning if no one gets to it before then.

Sean
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux