On Wed, Sep 21, 2016 at 10:59:24AM +0200, Daniel Vetter wrote:
> Just pure code movement, cleanup and polish will happen in later
> patches.
>
> v2: Don't forget all the ioctl! To extract those cleanly I decided to
> put check_src_coords into drm_framebuffer.c (and give it a
> drm_framebuffer_ prefix), since that just checks framebuffer
> constraints.
>
> v3: rebase over PAGE_FLIP_TARGET.
>
> Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> ---
> Documentation/gpu/drm-kms.rst | 12 +
> drivers/gpu/drm/Makefile | 3 +-
> drivers/gpu/drm/drm_crtc.c | 991 +-----------------------------------
> drivers/gpu/drm/drm_crtc_internal.h | 38 +-
> drivers/gpu/drm/drm_framebuffer.c | 26 +
> drivers/gpu/drm/drm_plane.c | 990 +++++++++++++++++++++++++++++++++++
> include/drm/drm_atomic.h | 154 ++++++
> include/drm/drm_crtc.h | 583 +--------------------
> include/drm/drm_plane.h | 470 +++++++++++++++++
> 9 files changed, 1681 insertions(+), 1586 deletions(-)
> create mode 100644 drivers/gpu/drm/drm_plane.c
<snip>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 2318daa8911d..edc87b8168a0 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
<snip>
> -/**
> - * struct drm_atomic_state - the global state object for atomic updates
> - * @dev: parent DRM device
> - * @allow_modeset: allow full modeset
> - * @legacy_cursor_update: hint to enforce legacy cursor IOCTL semantics
> - * @legacy_set_config: Disable conflicting encoders instead of failing with -EINVAL.
> - * @planes: pointer to array of structures with per-plane data
> - * @crtcs: pointer to array of CRTC pointers
> - * @num_connector: size of the @connectors and @connector_states arrays
> - * @connectors: pointer to array of structures with per-connector data
> - * @acquire_ctx: acquire context for this atomic modeset state update
> - */
> -struct drm_atomic_state {
> - struct drm_device *dev;
> - bool allow_modeset : 1;
> - bool legacy_cursor_update : 1;
> - bool legacy_set_config : 1;
> - struct __drm_planes_state *planes;
> - struct __drm_crtcs_state *crtcs;
> - int num_connector;
> - struct __drm_connnectors_state *connectors;
> -
> - struct drm_modeset_acquire_ctx *acquire_ctx;
> -
> - /**
> - * @commit_work:
> - *
> - * Work item which can be used by the driver or helpers to execute the
> - * commit without blocking.
> - */
> - struct work_struct commit_work;
> -};
../drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_atomic_check’:
../drivers/gpu/drm/tilcdc/tilcdc_crtc.c:484:18: error: dereferencing pointer to incomplete type
../drivers/gpu/drm/tilcdc/tilcdc_crtc.c:485:18: error: dereferencing pointer to incomplete type
../drivers/gpu/drm/tilcdc/tilcdc_crtc.c:486:18: error: dereferencing pointer to incomplete type
:(
Sean
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
