Hi Daniel, Thanks for the review. On Wednesday 21 Sep 2016 09:34:13 Daniel Vetter wrote: > On Thu, Sep 08, 2016 at 05:44:16PM +0300, Laurent Pinchart wrote: > > Turn the drm_format_*() helpers into wrappers around the drm_format_info > > lookup function to centralize all format information in a single place. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > > > drivers/gpu/drm/drm_fourcc.c | 186 +++++++------------------------------ > > 1 file changed, 37 insertions(+), 149 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > > index 6b91bd8a510d..bf91c5044d84 100644 > > --- a/drivers/gpu/drm/drm_fourcc.c > > +++ b/drivers/gpu/drm/drm_fourcc.c > > @@ -198,69 +198,22 @@ EXPORT_SYMBOL(drm_format_info); > > > > void drm_fb_get_bpp_depth(uint32_t format, unsigned int *depth, > > int *bpp) [snip] > > + > > + *depth = info->depth; > > + *bpp = info->cpp[0] << 3; > > Bikeshed: This is a funny way to write * 8 ... Would be nice to fix imo. Fixed. > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
