On Tue, Sep 20, 2016 at 01:07:35PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > > > A single error message should be sufficient to inform about > > the detection of an unknown GCT revision at the end. > > Thus return after the logging call in this case directly. > > Did you test this? > Don't be a dummy... This is easy to review an it fixes a bug. I'm fine with you NAKing all these patches based on who they are from. I mostly just delete these without responding because the guy has history of introducing bugs and never listens to feedback. But asking pointless rhetorical questions is not helpful. A lot of people are CC'd and you're wasting everyone's time by asking questions where you know the answer. regards, dan carpenter _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel