Re: [PATCH] drm/amdgpu: add missing header dependencies

Christian König <christian.koenig@xxxxxxx> · Mon, 19 Sep 2016 11:59:23 +0200

Am 18.09.2016 um 15:12 schrieb Baoyou Xie:
We get 6 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:629:6: warning: no previous prototype for 'dce_v8_0_disable_dce' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:730:6: warning: no previous prototype for 'dce_v10_0_disable_dce' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:699:6: warning: no previous prototype for 'dce_v11_0_disable_dce' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:40:5: warning: no previous prototype for 'amdgpu_gfx_scratch_get' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:62:6: warning: no previous prototype for 'amdgpu_gfx_scratch_free' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:84:6: warning: no previous prototype for 'amdgpu_gfx_parse_disable_cu' [-Wmissing-prototypes]

In fact, these functions are declared in
drivers/gpu/drm/amd/amdgpu/dce_v8_0.h
drivers/gpu/drm/amd/amdgpu/dce_v10_0.h
drivers/gpu/drm/amd/amdgpu/dce_v11_0.h
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h,
so this patch adds missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 +
  drivers/gpu/drm/amd/amdgpu/dce_v10_0.c  | 1 +
  drivers/gpu/drm/amd/amdgpu/dce_v11_0.c  | 1 +
  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c   | 1 +
  4 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index a074edd..01a42b6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -24,6 +24,7 @@
   */
  #include <drm/drmP.h>
  #include "amdgpu.h"
+#include "amdgpu_gfx.h"
  
  /*
   * GPU scratch registers helpers function.
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
index bc5bb4e..fb943ee 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
@@ -35,6 +35,7 @@
  #include "dce/dce_10_0_d.h"
  #include "dce/dce_10_0_sh_mask.h"
  #include "dce/dce_10_0_enum.h"
+#include "dce_v10_0.h"
  #include "oss/oss_3_0_d.h"
  #include "oss/oss_3_0_sh_mask.h"
  #include "gmc/gmc_8_1_d.h"
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
index b93eba0..1555d6d 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
@@ -35,6 +35,7 @@
  #include "dce/dce_11_0_d.h"
  #include "dce/dce_11_0_sh_mask.h"
  #include "dce/dce_11_0_enum.h"
+#include "dce_v11_0.h"
  #include "oss/oss_3_0_d.h"
  #include "oss/oss_3_0_sh_mask.h"
  #include "gmc/gmc_8_1_d.h"
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
index abd5213..ef7add9 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
@@ -34,6 +34,7 @@
  
  #include "dce/dce_8_0_d.h"
  #include "dce/dce_8_0_sh_mask.h"
+#include "dce_v8_0.h"
  
  #include "gca/gfx_7_2_enum.h"
  


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel







