Re: [PATCH 6/4] arm: dts: qcom: apq8064-nexus7: Add DSI and panel nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Regards,
vinay simha


On Thu, Sep 8, 2016 at 5:02 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> Tagging on to Archit's patchset here.
>
> Add DSI and panel nodes to get graphics up and running
> on the Nexus7.
>
> This still depends on the panel driver being present
> (currently under review) along with the rpmclk code.
>
> Feedback would be appreciated here!
>
> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Cc: vinay simha <vinaysimha@xxxxxxxxxxxxxxxxxxxx>
> Cc: andy.gross@xxxxxxxxxx
> Cc: robdclark@xxxxxxxxx
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 78 +++++++++++++++++++++-
>  1 file changed, 76 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> index ff856c3..e25a764 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -27,6 +27,18 @@
>                 regulator-boot-on;
>         };
>
> +       vcc_1p8v: regulator-fixed@2 {
> +               compatible = "regulator-fixed";
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <1800000>;
> +               regulator-name = "vcc_1p8v";
> +               regulator-type = "voltage";
> +               startup-delay-us = <0>;
> +               gpio = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;
> +               enable-active-high;
> +               regulator-boot-on;
> +       };
> +
We can remove the vcc_1p8v, some modification had done in the panel tree
>         gpio-keys {
>                 compatible = "gpio-keys";
>                 volume_up {
> @@ -99,6 +111,7 @@
>                                 l2 {
>                                         regulator-min-microvolt = <1200000>;
>                                         regulator-max-microvolt = <1200000>;
> +                                       regulator-always-on;
>                                 };
>
>                                 /* msm_otg-HSUSB_3p3 */
> @@ -133,13 +146,14 @@
>                                         regulator-min-microvolt = <3000000>;
>                                         regulator-max-microvolt = <3000000>;
>                                         bias-pull-down;
> +                                       regulator-always-on;
>                                 };
>
>                                 /* pwm_power for backlight */
>                                 l17 {
>                                         regulator-min-microvolt = <3000000>;
> -                                       regulator-max-microvolt = <3600000>;
> -                                       bias-pull-down;
> +                                       regulator-max-microvolt = <3000000>;
> +                                       regulator-always-on;
>                                 };
>
>                                 /* camera, qdsp6 */
> @@ -184,6 +198,66 @@
>                         };
>                 };
>
> +               mdp@5100000 {
> +                       status = "okay";
> +                       ports {
> +                               port@1 {
> +                                       mdp_dsi1_out: endpoint {
> +                                               remote-endpoint = <&dsi0_in>;
> +                                       };
> +                               };
> +                       };
> +               };
> +
> +               dsi0: qcom,mdss_dsi@4700000 {
> +                       status = "okay";
> +                       vdda-supply = <&pm8921_l2>;/*VDD_MIPI1 to 4*/
> +                       vdd-supply = <&pm8921_l8>;
> +                       vddio-supply = <&pm8921_lvs7>;
> +                       avdd-supply = <&pm8921_l11>;
> +                       vcss-supply = <&ext_3p3v>;
> +
> +                       panel@0 {
> +                               reg = <0>;
> +                               compatible = "jdi,lt070me05000";
> +
> +                               pinctrl-names = "default";
> +                               pinctrl-0 = <&dsi_panel_pinctrl>;
> +
> +                               vddp-supply = <&pm8921_l17>;
> +                               dcdc_en-supply = <&pm8921_lvs7>;
> +                               vcc-supply = <&vcc_1p8v>;
> +
> +                               reset-gpios = <&tlmm_pinmux 54 0>;
> +                               enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
> +
We can remove the pinctrl-names and pinctrl-0, have the below contents
lilke this
  panel@0 {
                      compatible = "jdi,lt070me05000";
                      reg = <0>;

                      vddp-supply = <&pm8921_l17>;
                      iovcc-supply = <&pm8921_lvs7>;

                       enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
                       reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
                       dcdc-en-gpios = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;

> +                               port {
> +                                       panel_in: endpoint {
> +                                               remote-endpoint = <&dsi0_out>;
> +                                       };
> +                               };
> +                       };
> +                       ports {
> +                               port@0 {
> +                                       dsi0_in: endpoint {
> +                                               remote-endpoint = <&mdp_dsi1_out>;
> +                                       };
> +                               };
> +
> +                               port@1 {
> +                                       dsi0_out: endpoint {
> +                                               remote-endpoint = <&panel_in>;
> +                                               data-lanes = <0 1 2 3>;
> +                                       };
> +                               };
> +                       };
> +               };
> +
> +               mdp_dsi_phy0: qcom,mdss_dsi_phy@4700200 {
> +                       status = "okay";
> +                       vddio-supply = <&pm8921_lvs7>;/*VDD_PLL2_1 to 7*/
> +               };
> +
>                 gsbi@16200000 {
>                         status = "okay";
>                         qcom,mode = <GSBI_PROT_I2C>;
> --
> 1.9.1
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux