On 7 September 2016 at 11:27, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> wrote: > Hi, > > this series basically takes the facility for continuously capturing CRCs > of frames from the i915 driver and into the DRM core. > > The idea is that test suites such as IGT use this information to check > that frames that are exected to be identical, also have identical CRC > values. > > Other drivers for hardware that can provide frame CRCs (including eDP > panels that support self-refresh) can easily implement the new callback > and provide userspace with the CRC values. > > Thanks, > > Tomeu > > Tomeu Vizoso (4): > drm/i915/debugfs: Move out pipe CRC code > drm: Add API for capturing frame CRCs > drm/i915: Use new CRC debugfs API > drm/i915: Put "cooked" vlank counters in frame CRC lines > Thanks for the nice work and addressing my suggestions Tomeu. I think I've spotted a bug in 2/4, plus there's a couple of trivial nitpicks in 2/4 and 3/4 - either of which can be fixed as a follow up (if I haven't lost it of course). With the bug trivially fixed the series is: Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel