On 09/08/16 14:08, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_panel.c:443:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/tilcdc/tilcdc_tfp410.h, > drivers/gpu/drm/tilcdc/tilcdc_panel.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> I'll pick this up. Thanks, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 + > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index ff7774c..979394d 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -24,6 +24,7 @@ > #include <video/videomode.h> > > #include "tilcdc_drv.h" > +#include "tilcdc_panel.h" > > struct panel_module { > struct tilcdc_module base; > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index 6b8c5b3..455f032 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -22,6 +22,7 @@ > #include <linux/pinctrl/consumer.h> > > #include "tilcdc_drv.h" > +#include "tilcdc_tfp410.h" > > struct tfp410_module { > struct tilcdc_module base; > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel