Re: [PATCH v2 5/5] drm/tilcdc: WARN if CRTC is touched without CRTC lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/09/16 23:59, Jyri Sarha wrote:
> WARN if CRTC is touched without CRTC lock. The crtc functions should
> not be called simultaneously from multiple threads. Having the DRM
> CRTC lock should take care of that.
> 
> tilcdc_crtc_destroy() has to take the CRTC lock befor calling
> tilcdc_crtc_disable() because drm_mode_config_cleanup() does not take
> the lock. If this ever changes the CRTC locking has to be removed from
> tilcdc_crtc_destroy().

Shouldn't these be two separate patches? This one is (according to
subject) adding WARNs, but it is actually also adding locking.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux