On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > The A33 has a significantly different pipeline, with components that differ > too. > > Make sure we had compatible for them. > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++++- > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 +++++--- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 +++++++- > 4 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index df8f4aeefe4c..bd3136a5cba5 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -26,7 +26,9 @@ TCON > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > Required properties: > - - compatible: value should be "allwinner,sun5i-a13-tcon". > + - compatible: value must be either: > + * allwinner,sun5i-a13-tcon > + * allwinner,sun8i-a33-tcon > - reg: base address and size of memory-mapped region > - interrupts: interrupt associated to this IP > - clocks: phandles to the clocks feeding the TCON. Three are needed: You should probably put a note saying the A33 only needs 2 clocks. You can keep my ack after fixing it. ChenYu _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel