Re: [PATCH v3] drm/bridge: analogix_dp: Remove duplicated code

[Yakir Yang <ykk@xxxxxxxxxxxxxx>]

On 08/24/2016 10:54 PM, Sean Paul wrote:

From: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>

Remove code for reading the EDID and DPCD fields and use the helpers
instead.

Besides the obvious code reduction, other helpers are being added to the
core that could be used in this driver and will be good to be able to
use them instead of duplicating them.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Tested-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Cc: Mika Kahola <mika.kahola@xxxxxxxxx>
Cc: Yakir Yang <ykk@xxxxxxxxxxxxxx>
Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>

Reviewed-by: Yakir Yang <ykk@xxxxxxxxxxxxxx>

---

v2:
    - A bunch of good fixes from Sean and Yakir
    - Moved the transfer function to analogix_dp_reg.c
    - Removed reference to the EDID from the dp struct

v3:
    - Rebased on top of Yakir's PSR series
    - Fixed checkpatch warning about line length


 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 274 ++++---------
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |  40 +-
 drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c  | 451 ++++++---------------
 3 files changed, 210 insertions(+), 555 deletions(-)

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel