Am Sonntag, den 21.08.2016, 19:32 -0300 schrieb Fabio Estevam: > There is no need to initialize variable 'err' with 0 because it will > be properly assigned later on. > > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > index d93eb8c..27f34f5 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > @@ -1652,7 +1652,7 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct etnaviv_gpu *gpu; > - int err = 0; > + int err; This looks like churn to me, and I wouldn't take this patch if it would stand on its own. But as it's part of the series and the other 2 patches look good to me, I'll take the whole series. Thanks, Lucas _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel