Hi Daniel, On 17 August 2016 at 21:56, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > --- /dev/null > +++ b/include/drm/drm_property.h > +#ifndef __DRM_PROPERTY_H__ > +#define __DRM_PROPERTY_H__ > + > +#include <linux/list.h> > +#include <linux/ctype.h> > +#include <drm/drm_mode_object.h> > + Add the following fwd declaration since we use a pointer to the said struct ? From a brief look the other newly introduced headers could/should use it as well. struct drm_device; The declarations in include/drm should be the ones meant for drivers and there's no core drm internal ones ? Where/how does one manage API that should be kept private between the different core DRM components, even if there's symbol dependency between the different modules ? Thanks ! Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel