On Fri, Aug 12, 2016 at 03:03:31PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 12, 2016 at 01:15:37PM +0800, Shawn Guo wrote: > > The drm driver feature flag DRIVER_HAVE_IRQ is used to indicates whether > > the driver has an IRQ handler managed by the DRM core. Some drivers, > > armada, etnaviv, kirin and sti, set this flag without .irq_handler setup > > in drm_driver. These drivers manage IRQ handler by themselves and the > > flag DRIVER_HAVE_IRQ makes no sense there. > > It's worth noting that DRIVER_HAVE_IRQ was required prior to: > > commit 4984979b9b9025a1cb9a9bea089d31a3e01ccff1 > Author: Daniel Vetter <daniel.vetter@xxxxxxxx> > Date: Wed Aug 28 15:02:37 2013 +0200 > > drm/irq: simplify irq checks in drm_wait_vblank > > to have working vblank. As this is no longer the case, this change > looks sane. Okay, I will improve the commit log and send v2 soon. > > > > > Drop the flag for these drivers to avoid confusion. > > > > Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx> > > --- > > drivers/gpu/drm/armada/armada_drv.c | 2 +- > > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +-- > > For both of these, > > Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> Thanks, Russell. Shawn _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
