Reviewed-by: Sinclair Yeh <syeh@xxxxxxxxxx> On Tue, Aug 02, 2016 at 06:50:25PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 9fcd820..b8e5d3d 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -240,15 +240,15 @@ static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val, > void *ptr); > > MODULE_PARM_DESC(enable_fbdev, "Enable vmwgfx fbdev"); > -module_param_named(enable_fbdev, enable_fbdev, int, 0600); > +module_param_named(enable_fbdev, enable_fbdev, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(force_dma_api, "Force using the DMA API for TTM pages"); > -module_param_named(force_dma_api, vmw_force_iommu, int, 0600); > +module_param_named(force_dma_api, vmw_force_iommu, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(restrict_iommu, "Try to limit IOMMU usage for TTM pages"); > -module_param_named(restrict_iommu, vmw_restrict_iommu, int, 0600); > +module_param_named(restrict_iommu, vmw_restrict_iommu, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(force_coherent, "Force coherent TTM pages"); > -module_param_named(force_coherent, vmw_force_coherent, int, 0600); > +module_param_named(force_coherent, vmw_force_coherent, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(restrict_dma_mask, "Restrict DMA mask to 44 bits with IOMMU"); > -module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, 0600); > +module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR); > > > static void vmw_print_capabilities(uint32_t capabilities) > -- > 2.9.2 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
