I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/gpu/drm/i2c/ch7006_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index 0594c45..bfb4219 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -530,17 +530,17 @@ static void __exit ch7006_exit(void) } int ch7006_debug; -module_param_named(debug, ch7006_debug, int, 0600); +module_param_named(debug, ch7006_debug, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(debug, "Enable debug output."); char *ch7006_tv_norm; -module_param_named(tv_norm, ch7006_tv_norm, charp, 0600); +module_param_named(tv_norm, ch7006_tv_norm, charp, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(tv_norm, "Default TV norm.\n" "\t\tSupported: PAL, PAL-M, PAL-N, PAL-Nc, PAL-60, NTSC-M, NTSC-J.\n" "\t\tDefault: PAL"); int ch7006_scale = 1; -module_param_named(scale, ch7006_scale, int, 0600); +module_param_named(scale, ch7006_scale, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(scale, "Default scale.\n" "\t\tSupported: 0 -> Select video modes with a higher blanking ratio.\n" "\t\t\t1 -> Select default video modes.\n" -- 2.9.2 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
