I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/gpu/drm/bochs/bochs_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 207a2cb..95feb47 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -11,8 +11,8 @@ static int defx = 1024; static int defy = 768; -module_param(defx, int, 0444); -module_param(defy, int, 0444); +module_param(defx, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(defy, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(defx, "default x resolution"); MODULE_PARM_DESC(defy, "default y resolution"); -- 2.9.2 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
