Hi ----- Original Message ----- > On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring <robh@xxxxxxxxxx> wrote: > > Hi, > > > > This commit in virglrenderer causes a regression in Android for me. > > The parameters that get passed in are last_level = 8, width = 1. I'm > > not really sure if this is valid (I'm guessing there should be some > > min width?), or where I should be looking to fix this. Any ideas? > > what is the height? last mip-map level is basically the number of > times you could half the width+height (round up to 1) until it is 1x1. > So something like 1x512 would have last_level=8. (I might be off by > one right-shift..) > > Try this: > > - if (args->last_level > (floor(log2(MAX2(args->width, args->width))) + 1)) > + if (args->last_level > (floor(log2(MAX2(args->width, args->height))) + 1)) Oh, looks like what I wanted but I wouldn't see the typo even after re-reading... please send a patch on the virgl mailing list. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
