2016-07-28 14:55 GMT+02:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: > Hi Benjamin, > > Just spotted a couple of small bits which, imho, should be fine with > squashing with follow up patch(es). > > On 28 July 2016 at 09:07, Benjamin Gaignard > <benjamin.gaignard@xxxxxxxxxx> wrote: > >> +EXPORT_SYMBOL(drm_atomic_helper_normalize_zpos); > The symbols is internal only thus the EXPORT_SYMBOL notation isn't needed. > Rule of thumb - interfaces used by other modules are declared in > include/drm and the symbol(s) should be annotated with EXPORT_SYMBOL* > drm_blend.c is linked into drm.o while drm_atomic_helper_normalize_zpos is used in drm_atomic_helper.c linked within drm_kms_helper.o so EXPORT_SYMBOL is need either I got linked error while compiling drm as a module >> + >> +int drm_plane_atomic_set_zpos_property(struct drm_plane *plane, >> + struct drm_plane_state *state, >> + struct drm_property *property, >> + uint64_t val); >> + >> +int drm_plane_atomic_get_zpos_property(struct drm_plane *plane, >> + const struct drm_plane_state *state, >> + struct drm_property *property, >> + uint64_t *val); >> + > Dead code/declarations ? > yes dead code, I will remove it. > Cheers, > Emil Thanks, Benjamin -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
