On Fri, Jul 22, 2016 at 5:32 AM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Fri, 22 Jul 2016 11:20:27 +0200 > > The drm_gem_object_unreference_unlocked() function tests whether > its argument is NULL and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Applied to drm-misc > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c > index 615cbb0..13798b3 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_main.c > +++ b/drivers/gpu/drm/mgag200/mgag200_main.c > @@ -17,8 +17,8 @@ > static void mga_user_framebuffer_destroy(struct drm_framebuffer *fb) > { > struct mga_framebuffer *mga_fb = to_mga_framebuffer(fb); > - if (mga_fb->obj) > - drm_gem_object_unreference_unlocked(mga_fb->obj); > + > + drm_gem_object_unreference_unlocked(mga_fb->obj); > drm_framebuffer_cleanup(fb); > kfree(fb); > } > -- > 2.9.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel