Am 16.07.2016 17:08, schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 16 Jul 2016 15:36:36 +0200
>
> The variable "temp_storage" was eventually reassigned with a pointer.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> index 024e22e..735aeb0 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> @@ -60,7 +60,7 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
> void *input, void *output)
> {
> int result = 0;
> - void *temp_storage = NULL;
> + void *temp_storage;
>
> if (hwmgr == NULL || rt_table == NULL) {
> printk(KERN_ERR "[ powerplay ] Invalid Parameter!\n");
> @@ -73,7 +73,8 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
> printk(KERN_ERR "[ powerplay ] Could not allocate table temporary storage\n");
> return -ENOMEM;
> }
> - }
> + } else
> + temp_storage = NULL;
>
> result = phm_run_table(hwmgr, rt_table, input, output, temp_storage);
> kfree(temp_storage);
the handling of rt_table->storage_size == 0 is so better visible.
IMHO in this case the function could return directly either with -EINVAL;
or with 0; -> more direct more obvious.
if (rt_table->storage_size == 0 )
return 0;
re,
wh
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
