Re: [PATCH 4/6] drm/qxl: Remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 24, 2016 at 06:15:18PM +0100, Frank Binns wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> The QXL driver sets DRIVER_MODESET unconditionally, so testing for the
> absence of the feature will always fail.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/qxl/qxl_kms.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
> index 2319800..12b8dff 100644
> --- a/drivers/gpu/drm/qxl/qxl_kms.c
> +++ b/drivers/gpu/drm/qxl/qxl_kms.c
> @@ -310,10 +310,6 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags)
>  	struct qxl_device *qdev;
>  	int r;
>  
> -	/* require kms */
> -	if (!drm_core_check_feature(dev, DRIVER_MODESET))
> -		return -ENODEV;
> -
>  	qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL);
>  	if (qdev == NULL)
>  		return -ENOMEM;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux