emil, As you had suggested to drop the spurious returns in jdi_panel_unprepare and drop the return itself. But as i had mentioned earlier , we cannot drop the return function and void for jdi_panel_unprepare , since the drm fun* requires int as return type (drm_panel_funcs .unprepare). please do re-point out if i had still missed anything. fyi, v7: * emil review comments incorporated added ARRAY_SIZE in struct, regulator_bulk_disable in poweroff, gpios checks dropped. some returns cannot be dropped, since drm panel framework return type required. On Mon, Jul 11, 2016 at 5:50 PM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Sun, Jul 03, 2016 at 11:52:11PM +0100, Emil Velikov wrote: >> On 28 June 2016 at 16:59, Vinay Simha <simhavcs@xxxxxxxxx> wrote: >> > hi, >> > >> > Any further comments or reviews? >> > >> You still haven't covered my earlier suggestions, as such I cannot >> give you a r-b :-( They are not blockers by any means, but it'll be >> up-to the maintainer to ack/pick this up. >> >> Thierry ? > > Vinay, please address Emil's comments and resend. I also see that you > stopped sending the device tree bindings patch at some point. Please do > include that when you repost as I don't seem to be able to find a recent > version anywhere. > > Thierry -- Regards, Vinay Simha.B.N. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
