From: Fabio Estevam <fabio.estevam@xxxxxxx> There is no need for doing an extra 'or' operation when reading the return value from of_property_read_u32(). Just do a simple read instead. Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx> --- drivers/gpu/drm/imx/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index a52939c..2cf0631 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -594,7 +594,7 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) return ret; } - ret |= of_property_read_u32(np, "fsl,vsync-pin", + ret = of_property_read_u32(np, "fsl,vsync-pin", &tve->vsync_pin); if (ret < 0) { -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel