On Sat, Jul 02, 2016 at 03:17:08PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "workqueue" has only a single workitem(&ddata->ulps_work) per > panel_drv_data and hence doesn't require ordering. > Also, it is not being used on a memory reclaim path. Hence, the > singlethreaded workqueue has been replaced with the use of system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Occurrences of the label err_bl have also been removed because with the > usage of system_wq, calls to destroy_workqueue() have been dropped, > which makes the label unnecessary. > > Workitem is sync cancelled in dsicm_cancel_ulps_work() which is called > in dsicm_remove() to ensure that there are no workitems pending when the > driver is disconnected. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
