On 06/16/2016 11:22 PM, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2016 15:52:25 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> Add CEC support to the adv7842 driver. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > Won't review patches 10-13, as the same reviews I made for patch 9 > very likely applies. > > As this series is causing non-staging drivers to be dependent of a > staging driver, I'll wait for the next version that should be > solving this issue. > > For the new 9-13 patches, please be sure that checkpatch will be > happy. For the staging stuff, the checkpatch issues can be solved > later, as I'll re-check against checkpatch when it moves from staging > to mainstream. I have to make changes anyway so I'll make a new pull request later today fixing all the comments and replacing unsigned with unsigned int (which is a majority of all the checkpatch warnings). Did I mention yet how much I hate this new checkpatch warning? In almost all cases I agree with the checkpatch rules, but this one is just stupid IMHO. Oh well, I'll make the change. Perhaps it will grow on me over time. Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
