On Wed, Jun 15, 2016 at 10:37:24AM +0200, Paul Bolle wrote: > [Added Sinclair, Thomas, and "VMware Graphics".] > > On do, 2016-04-14 at 07:34 -0700, Joe Perches wrote: > > On Thu, 2016-04-14 at 13:32 +0200, Paul Bolle wrote: > > > On do, 2016-03-03 at 11:26 +0100, Paul Bolle wrote: > > > > > > > > Use the upper_32_bits() macro instead of the four line equivalent that > > > > triggers a GCC warning on 32 bits x86: > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function > > > > 'vmw_cmdbuf_header_submit': > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:297:25: warning: right > > > > shift count >= width of type [-Wshift-count-overflow] > > > > val = (header->handle >> 32); > > > > ^ > > > > > > > > And use the lower_32_bits() macro instead of and-ing with a 32 bits > > > > mask. > > > > > > > > Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx> > > > > --- > > > > Note: compile tested only (I don't use any of vmware's products). > > > The warning can still be seen on v4.6-rc3 for 32 bits x86. This patch > > > applies cleanly to that rc. > > > > > > Has anyone had a chance to look at this patch, and perhaps even test > > > it? > > > > Test? Nope. Seems obviously correct. > > This warning still shows up when building v4.7-rc3 for 32 bits x86. > > Since my previous message an entry for this driver showed up in > MAINTAINERS. So I'd guess Sinclair, Thomas, etc want me to resend this > small patch. Is that correct? Sounds more like maintainers asleep at the helm ;-) I've applied this to drm-misc, Sinclair can apply polish later on if he wants to. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
