> -----Original Message----- > From: Henrique de Moraes Holschuh [mailto:hmh@xxxxxxxxxx] > Sent: Saturday, May 28, 2016 4:49 AM > To: Scot Doyle <lkml14@xxxxxxxxxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>; Jean-Christophe Plagniol- > Villard <plagnioj@xxxxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Jeremy Kerr <jk@xxxxxxxxxx>; Ming Lei > <ming.lei@xxxxxxxxxxxxx>; Daney, David <David.Daney@xxxxxxxxxx>; > Dann Frazier <dann.frazier@xxxxxxxxxxxxx>; Peter Hurley > <peter@xxxxxxxxxxxxxxxxxx>; Pavel Machek <pavel@xxxxxx>; Jonathan Liu > <net147@xxxxxxxxx>; Alistair Popple <alistair@xxxxxxxxxxxx>; Jean-Philippe > Brucker <jean-philippe.brucker@xxxxxxx>; Chintakuntla, Radha > <Radha.Chintakuntla@xxxxxxxxxx>; Jiri Slaby <jslaby@xxxxxxxx>; David > Airlie <airlied@xxxxxxxx>; David Daney <ddaney.cavm@xxxxxxxxx>; dri- > devel@xxxxxxxxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; Linux Kernel > Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; stable > <stable@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals > > On Fri, 20 May 2016, Scot Doyle wrote: > > On Fri, 20 May 2016, Jeremy Kerr wrote: > > > >Then looks there are two fix patches acked & tested: > > > > > > > > - the patch in this thread > > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > > > >blink timer." > > > > https://lkml.org/lkml/2016/5/17/455 > > > > > > > >So which one will be pushed to linus? > > > > > > Not that it's my call, but we may want both; the first as a safety > > > measure to prevent an invalid cur_blink_jiffies ever being set, and the > > > second one to actually fix the initialisation of vc_cur_blink_ms (and > > > address the warning introduced by the first). > > > > Tomi / Greg, > > > > I'd suggest > > - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and > stable[4.2] > > - applying "fbcon: warn on invalid cursor blink intervals" to 4.7 > > - ignoring "fbcon: use default if cursor blink interval is not valid" > > > > Note: the patches don't depend on each other > > I applied both recommended patches on top of 4.4.11 for testing, and they > made things a lot better here. > > I suggest the second patch should be backported to stable too, might as well > fix this thing for good *and keep the door closed*. Is this patch available on some tree so that I can point to ? And hope it will make it to linux-next soon ? > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
