Re: [PATCH] drm/rockchip: fix compile warnings for 64-bit

[Caesar Wang <wxt@xxxxxxxxxxxxxx>]

在 2016年06月10日 01:46, Brian Norris 写道:
> Rockchip DRM does not yet build properly for ARM64, but we might as well
> get the printf formatting correct now, to avoid the following warnings:
>
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c: In function 'rockchip_drm_fbdev_create':
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:111:2: warning: format '%d' expects argument of type 'int', but argument 8 has type 'size_t' [-Wformat=]
>    DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%d\n",
>    ^
>
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function 'rockchip_gem_alloc_buf':
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:41:3: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'size_t' [-Wformat=]
>     DRM_ERROR("failed to allocate %#x byte dma buffer", obj->size);
>     ^
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Tested-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index f261512bb4a0..bab4cd18b6b0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -108,7 +108,7 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
>   	fbi->screen_size = rk_obj->base.size;
>   	fbi->fix.smem_len = rk_obj->base.size;
>   
> -	DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%d\n",
> +	DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%zu\n",
>   		      fb->width, fb->height, fb->depth, rk_obj->kvaddr,
>   		      offset, size);
>   
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 9c2d8a894093..059e902f872d 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -38,7 +38,7 @@ static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj,
>   					 &rk_obj->dma_addr, GFP_KERNEL,
>   					 &rk_obj->dma_attrs);
>   	if (!rk_obj->kvaddr) {
> -		DRM_ERROR("failed to allocate %#x byte dma buffer", obj->size);
> +		DRM_ERROR("failed to allocate %zu byte dma buffer", obj->size);
>   		return -ENOMEM;
>   	}
>   


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel