On Mon, 6 Jun 2016 21:20:56 +0900 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > The use of config_enabled() against config options is ambiguous. > In practical terms, config_enabled() is equivalent to IS_BUILTIN(), > but the author might have used it for the meaning of IS_ENABLED(). > Using IS_ENABLED(), IS_BUILTIN(), IS_MODULE() etc. makes the > intention clearer. > > This commit replaces config_enabled() with IS_ENABLED() where > possible. This commit is only touching bool config options. > > I noticed two cases where config_enabled() is used against a tristate > option: > > - config_enabled(CONFIG_HWMON) > [ drivers/net/wireless/ath/ath10k/thermal.c ] > > - config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE) > [ drivers/gpu/drm/gma500/opregion.c ] > > I did not touch them because they should be converted to IS_BUILTIN() > in order to keep the logic, but I was not sure it was the authors' > intention. Well, we do want to be able to remove config_enabled() altogether if we're going to do this. So please later send along a patch which makes a best-effort fix of the unclear usages and let's zap the thing. If those fixes weren't quite correct then there will be a build error (drivers/net/wireless/ath/ath10k/thermal.c) or no change in behaviour (drivers/gpu/drm/gma500/opregion.c). _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
