On 06/06/16 02:21, Laurent Pinchart wrote: >> Also, I do like it that we deal with crtc or plane interrupts in >> omap_crtc or omap_plane. Would similar approach here work as you use in >> the following patches, i.e. just call underflow-handler func in >> omap_plane.c directly, instead of using the registration mechanism? > > I can do that, but given that all we do is just printing error messages, it > sounds a bit overkill. I propose moving FIFO underflow IRQ handling to the > CRTC and plane code later when/if we need to perform more work in the > handlers. What's the overkill? Isn't it just making the function public, and calling that from omap_irq? And it's true your patch just prints an error message, but omap_irq_fifo_underflow() is still 35 lines, so it's not a one-liner. I don't feel strongly about this, though =). Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
