On Fri, Jun 3, 2016 at 10:36 AM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx> wrote: > On Fri, Jun 03, 2016 at 10:29:40AM -0500, Rob Herring wrote: >> On Fri, Jun 3, 2016 at 9:21 AM, Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote: >> > Add common OF-based component functionality for matching devices by >> > device node, and releasing the device node at the appropraite time. >> > >> > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> >> > --- >> > drivers/of/Makefile | 2 +- >> > drivers/of/of_component.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> > include/linux/of_component.h | 14 ++++++++++++++ >> >> I'd prefer this to go into drivers/base/component.c. That's the >> general direction we've been moving. > > I'd prefer not to, I don't want to turn the component helpers into > something OF specific. They aren't OF specific. Fine, not enough code to argue about... >> I'd expect this would cause some build failures unless the cases you >> converted all depend on CONFIG_OF. > > Okay, I'll stick with v1 then, and the duplication that v1 involves. Why? You don't want to add empty functions? Seems like good clean-up. Rob _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
