Re: [PATCH] drm/vc4: Make pageflip completion handling more robust.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mario Kleiner <mario.kleiner.de@xxxxxxxxx> writes:

> Protect both the setup of the pageflip event and the
> latching of the new requested displaylist head pointer
> by the event lock, so we can't get into a situation
> where vc4_atomic_flush latches the new display list via
> HVS_WRITE, then immediately gets preempted before queueing
> the pageflip event, then the page-flip completes in hw and
> the vc4_crtc_handle_page_flip() runs and no-ops due to
> lack of a pending pageflip event, then vc4_atomic_flush
> continues and only then queues the pageflip event - after
> the page flip handling already no-oped. This would cause
> flip completion handling only at the next vblank - one
> frame too late.

This patch is:

Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>

I'll try to get a pull request sent out for this shortly.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux