On Mon, May 23, 2016 at 09:40:59AM +0100, Emil Velikov wrote: > On 21 May 2016 at 15:08, Lukas Wunner <lukas@xxxxxxxxx> wrote: > > Daniel Vetter explicitly wanted the ability to use the helper in > > vga_switcheroo audio clients, and those shouldn't run the apple-gmux > > test. I think it makes sense to enclose it in the above-quoted if-block > > *now* even though it's not needed. Once someone adds a check for an > > audio client, chances are they'll forget to add this if-block. > > > Absolutely no arguments against any of that. Having a helper makes > sense even without any of the above arguments - it's a 'nasty looking' > if statement, duplicated multiple times. Speaking of which ... > shouldn't there be a similar hunk for amdgpu ? Currently vga_switcheroo_client_probe_defer() is only needed for the MacBook Pro and the AMD GPUs used by Apple are only supported by radeon. I've amended the commit message in v6 to explain that. > Then again throwing everything into one patch does _not_ make sense. > Don't know why people would insist on having re-factoring and > functionality change as a single commit. Esp. in a place where hw > combinations, and thus chances of things going wrong, are pretty high. Noone insists, v1 of this patch didn't contain the functional change you're taking exception to, I added it in v2 on Daniel's request and didn't want to complicate things further, seemed like a trivial change to me. Nevertheless I've spun this out into a separate commit now, no problem at all. Best regards, Lukas _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
