On Mon, May 30, 2016 at 02:17:06PM +0200, Maarten Lankhorst wrote: > Op 29-05-16 om 20:34 schreef Daniel Vetter: > > This avois leaking drm_atomic_state internals into the helpers. The > > only place where this still happens after this patch is drm_atomic_helper_swap_state(). > > It's unavoidable there, and maybe a good indicator we should actually > > move that function into drm_atomic.c. > Would be a good idea, commit is part of atomic core and there's really only one way to do swap_state. > Drivers can swap any required internal state before or after the call. Later on I'm adding some of the nonblocking stuff to swap_state, and I think at least the nonblocking support should be part of the helpers. I'm torn again about where to put it ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
