On 2016-05-27 05:20, Mark Brown wrote: > On Thu, May 26, 2016 at 10:54:16PM -0700, Stefan Agner wrote: >> On 2016-05-26 02:11, Alexander Stein wrote: > >> > This needs to be a flat cache. See >> > https://lists.freedesktop.org/archives/dri-devel/2016-January/099121.html >> > or https://lkml.org/lkml/2016/3/24/281 >> > max_register also needs an appropriate value. > >> FWIW, the latest patch which addresses this issue is Patch 5/6 of this >> patchset: >> https://lkml.org/lkml/2016/4/19/617 > >> Unfortunately, that patchset missed the 4.7 merge window. I still miss >> an Ack for the first patch of this patchset. But should go into the next >> release... > > That's another way of addressing it of course, but unless the register > map actually is sparse it's probably still sensible to send the > conversion to flat cache as a fix. The regcache is used for suspend, but the suspend implementation in its current form is not in not working. Hence I felt it is not worth fixing part of something which is broken as a whole anyway. So far I was under the impression the "only" issue using REGCACHE_RBTREE is that it triggers a warning when enabling lockdep. @Alexander, is using REGCACHE_RBTREE an actual problem for the issue Meng Yi has here? -- Stefan _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel