On 26/05/16 13:17, Daniel Vetter wrote: > On Thu, May 26, 2016 at 11:35:44AM +0300, Jyri Sarha wrote: >> Implements gamma tables for OMAP4, OMAP5, and dra7xx SoCs and adds a >> workaround for errata that may break LCD1 channel if gamma tables >> are in use. >> >> Also adds new drm_crtc_enable_color_mgmt() as suggested[1] by Daniel >> Vetter and get rid of the old drm_helper_crtc_enable_color_mgmt(). I >> have not tested the change to i915 driver, only compiled it, but >> functionally it should be exactly the same. >> >> [1] http://www.spinics.net/lists/dri-devel/msg108092.html > > Btw for testing it would be awesome if you could take the color manager > igt testcase we have, and make it generic. Probably needs some > adjustments like skip tests when not all properties which are needed are > there. We should already auto-skip crc-based tests when that's not there, > so hopefully not too much work. > > This way we could start to have something like real validation tests for > all these atomic extensions and make sure things do work across drivers in > a uniform way. Tomeu and Robert have done this conversion work thus far, > with Daniel leading the effort (all cc'ed). Lionel has done the color mgmt > test. I agree. And I have on my todo to have a look again at igt. Last time I looked there were really no tests that could be ran on our platforms, and I didn't have time to look at it further. And for those interested, I added a simple py script to kmsxx for hacking with gamma: https://github.com/tomba/kmsxx/blob/master/py/gamma.py Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
