On Wed, May 25, 2016 at 10:19:50PM +0100, Emil Velikov wrote: > On 25 May 2016 at 22:05, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > > On 25 May 2016 at 21:43, Jyri Sarha <jsarha@xxxxxx> wrote: > >> Add drm_crtc_enable_color_mgmt() to. The new function makes the old > >> drm_helper_crtc_enable_color_mgmt() obsolete. The new function is more > >> flexible. It allows driver to enable only the feature it has without > >> forcing to enable all three color management features: gegamma lut, csc > >> matrix (ctm), and gamma lut. > >> > > Why don't we just update the existing one ? In one step (patch) or two > > - a) don't register property if respective _lut_size is zero b) bring > > in has_ctm. > > > Ouch I missed that the goal here is to move the function out of > drm_crtc_helper.c. Sorry about that. The goal still was to move it, and update the existing callers. Adding a new without removing the old one is not what I suggested really ;-) -Daniel > > Perhaps the commit message can be reworded a bit - something like the > following comes to mind. > > "Introduce drm_crtc_enable_color_mgmt() function which supersedes the > crtc_helper one (xxx: add name). The latter always creates all > properties (xxx: list props) and is not really a helper. > The new version allows explicit control of the properties created as > required by some hardware/drivers (xxx: name driver)." > > Feel free to reuse and/tweak. > > Thanks > Emil > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
