On 25 May 2016 at 17:40, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: >> On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >>> > > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> >>> > > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> >>> > >>> > Standard request from my side for new drm drivers (especially if they're >>> > this simple): Can you please update the drivers to latest drm internal >>> > interfaces, i.e. using universal planes and atomic? >>> >>> Up'n'running. Incremental patch: >>> >>> https://www.kraxel.org/cgit/linux/commit/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a >>> >>> v2 coming, but I'll go over the other reviews first. >> >> Looking good. Wrt pageflip the current MO is to handroll it in your >> driver, common approach is to use the msm async commit implementation >> msm_atomic_commit. The issue is simply that right now there's still no >> useable generic vblank callback support (drm_irq.c is a mess) hence why >> the core helpers don't support async flips yet. > > I guess I didn't do a good job at looking at your v2: Cursor is still > using legacy interfaces and not a proper plane. Would be awesome if > you could fix that up. Atomic drivers really shouldn't use the legacy > cursor interfaces any more at all. Wild idea: Worth adding if (drm_core_check_feature(dev, DRIVER_ATOMIC) { printf("abort abort"); return; } style of checks for the legacy (preatomic) kms helpers ? Or does it feel like an overkill ? -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
