>> >> +struct displayid_detailed_timings_1 { >> + u8 pixel_clock[3]; >> + u8 flags; >> + u8 hactive[2]; >> + u8 hblank[2]; >> + u8 hsync[2]; >> + u8 hsw[2]; >> + u8 vactive[2]; >> + u8 vblank[2]; >> + u8 vsync[2]; >> + u8 vsw[2]; > > An alternative would be to declare these fields as __le16, and you could > read them in drm_mode_displayid_detailed() using le16_to_cpu(). We don't do that for the EDID structs, so I'd rather avoid it here as well. The spec is always in terms of 8-bit values. > > Anyway, these structs should be __packed. Indeed. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel