On Mon, May 02, 2016 at 10:08:21PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Here's a respin of my DP++ adaptor support series [1]. Pardon for taking > forever with this. Presumably we want to get this into stable to fix the > regression from HDMI 12bpc support. > > I've tried to account for a bunch of Paulo's review comments > > I also tried to make the helper a bit easier to use by having the caller > pass the adaptor type to the helper functions, and so the need for most > adaptor type checks in driver code is eliminated. I still left some > checks in i915, but those are there just to do the type 1 DVI vs. none > detectio, and to suppress the debug output when no adaptor is detected. > > I also redid the detection logic a bit to ease future LSPCON enabling. > > I had to rebase a bunch of stuff due to VBT shuffling. I also noticed > that my BSW still wasn't detecting type 1 DVI adaptors, which I managed > to "fix" by having the VBT check also accept HDMI type dvo_ports as DP++ > ports, which sucks a bit but should hopefully be robust enough. > > I felt that things changed a bit too much in the end for me to hang > on to the r-bs unfortunately, so I didn't actually pick them up. So > if people aren't too fed up with this, I'd appreciate them having a > a second look. > > Series available here: > git://github.com/vsyrjala/linux.git dp_dual_mode_3 > > [1] https://lists.freedesktop.org/archives/dri-devel/2016-February/101494.html > > Ville Syrjälä (4): > drm: Add helper for DP++ adaptors > drm/i915: Respect DP++ adaptor TMDS clock limit > drm/i915: Enable/disable TMDS output buffers in DP++ adaptor as needed > drm/i915: Determine DP++ type 1 DVI adaptor presence based on VBT Got Dave's ack for merging the helper via drm-intel, so I pushed the entire series to dinq. Thanks for the reviews everyone. > > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/drm_dp_dual_mode_helper.c | 356 ++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/intel_bios.c | 36 +++ > drivers/gpu/drm/i915/intel_ddi.c | 12 + > drivers/gpu/drm/i915/intel_drv.h | 6 + > drivers/gpu/drm/i915/intel_hdmi.c | 100 ++++++++- > drivers/gpu/drm/i915/intel_vbt_defs.h | 13 ++ > include/drm/drm_dp_dual_mode_helper.h | 83 +++++++ > 9 files changed, 600 insertions(+), 9 deletions(-) > create mode 100644 drivers/gpu/drm/drm_dp_dual_mode_helper.c > create mode 100644 include/drm/drm_dp_dual_mode_helper.h > > -- > 2.7.4 -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
