>> */ >> + if (connector && state->crtc) { >> + drm_connector_unreference(state->connector); >> + } > > Bikeshed: no need for {} and you don't need to check that connector is > NULL either. Tbh all the destroy_state helpers don't really need their > object argument, only the state. Cleaning that up is somewhere on my todo. Yes you really do need the connector, lost a boot to an oops, drm_atomic_state_default_clear does some funky stuff that can possibly go away after this, but I'm not sure. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel