On Tue, Apr 26, 2016 at 10:09:16PM +0100, Chris Wilson wrote: > On Tue, Apr 26, 2016 at 07:29:34PM +0200, Daniel Vetter wrote: > > It has a DRIVER_MODESET check to sure make it's not creating havoc > > for drm drivers. Make that clear in the name too. > > The pattern is that any extern that starts > > if (drm_core_check_feature(MODESET)) return > > becomes drm_legacy_ ? With the apparent caveat of KMS_LEGACY_CONTEXT. Yeah that's what I'm aiming for. Gives you a clear signal that as soon as you spot drm_legacy_* you don't have to bother jumping into the function at all. We've done the same with headers, splitting things into legacy internal headers. > > v2: Move misplaced hunk, spotted by 0day and Thierry. > > > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks for the review, will apply. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel