Re: [PATCH v2 1/3] drm/msm/hdmi: Prevent gpio_free related kernel warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 04/25/2016 11:18 PM, twp@xxxxxxxxxxxxxx wrote:
On 2016-04-25 03:16, Archit Taneja wrote:
Calling the legacy gpio_free on an invalid GPIO (a GPIO numbered -1)
results in kernel warnings. This causes a lot of backtraces when
we try to unload the drm/msm module.

Call gpio_free only on valid GPIOs.

Signed-off-by: Archit Taneja <architt@xxxxxxxxxxxxxx>
---
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
index 26129bf..ce86117 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
@@ -112,13 +112,16 @@ static int gpio_config(struct hdmi *hdmi, bool on)
         for (i = 0; i < HDMI_MAX_NUM_GPIO; i++) {
             struct hdmi_gpio_data gpio = config->gpios[i];

-            if (gpio.output) {
-                int value = gpio.value ? 0 : 1;
+            if (gpio.num != -1) {
+                if (gpio.output) {
+                    int value = gpio.value ? 0 : 1;

-                gpio_set_value_cansleep(gpio.num, value);
-            }
+                    gpio_set_value_cansleep(gpio.num,
+                                value);
+                }

-            gpio_free(gpio.num);
+                gpio_free(gpio.num);
+            }

Can you do something like:

if (gpio.num == -1)
     continue;

instead? That would avoid the additional indentation (and increase
readability).

Yes, that should make things cleaner. I'll make this change.

Thanks,
Archit

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux